Skip to content

Conversation

@medikoo
Copy link
Contributor

@medikoo medikoo commented Jul 16, 2021

Fixes #446
Fixes #439

Breaking change, as this drops support for old variables resolver, sp effectively drops support for version of Framework below v2.32.0 (reflected that by registering serverless as peer dependency).

Additionally upgraded internal tests so they work with v2 version of a Framework.

After this is merged, I believe ideally v3.0.0 needs to be released.

Having that done, it'll be nice to create a maintenance release for v2 branch where serverless is registered as peer dependency but with support for >=1 <2.32 (once v2 branch is setup I'll be happy to also prepare PR for that)

medikoo added 2 commits July 16, 2021 14:44
BREAKING CHANGE:
Drop support for old Serverless Framework variables resolver.
@horike37
Copy link
Collaborator

@medikoo
Thanks! I will take a look at this PR.

@medikoo
Copy link
Contributor Author

medikoo commented Jul 23, 2021

Great thanks @horike37 !

horike37 added 2 commits July 29, 2021 18:25
Copy link
Collaborator

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@medikoo
I tested and checked your PR and looks good from my perspective!
After merging, I will prepare to release v3

@horike37 horike37 merged commit c48d99d into serverless-operations:master Jul 31, 2021
@horike37
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@medikoo
Copy link
Contributor Author

medikoo commented Aug 9, 2021

@horike37 great thanks for publishing this!

@medikoo medikoo deleted the 0716-upgrade-to-latest-serverless branch August 9, 2021 15:06
ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
…e-to-latest-serverless

Upgrade to new Serverless Framework variables resolver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New ${aws:xxx} variables added in serverless 2.50.0 and this plugin breaks packaging / deployment Deploy fails just after adding the plugin

2 participants