Skip to content

fix: added iam permission for x-ray #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix: added iam permission for x-ray #375

merged 1 commit into from
Sep 18, 2020

Conversation

hassaku63
Copy link
Contributor

#373

It generates IAM permission for StateMachine to use X-Ray when enabled tracingConfig.

(Should I rename commit type 'feat' to 'fix'?)

@horike37
Copy link
Collaborator

@hassaku63
Thank you for fixing the IAM roles settings 👍
The code looks good from my perspective.

(Should I rename commit type 'feat' to 'fix'?)

Would be better to rename the 'fix' type since that will automatically introduce the minor version up.
Can you update the commit message? Afterward. We can merge and release it.

Copy link
Collaborator

@theburningmonk theburningmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hassaku63
Copy link
Contributor Author

@horike37 Thanks for your review. I changed to "fix".

@hassaku63 hassaku63 changed the title feat: added iam permission for x-ray fix: added iam permission for x-ray Sep 18, 2020
@horike37
Copy link
Collaborator

@hassaku63
Thank you for updating 👍

@horike37 horike37 merged commit 3f59c38 into serverless-operations:master Sep 18, 2020
@horike37
Copy link
Collaborator

🎉 This PR is included in version 2.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hassaku63 hassaku63 deleted the feature/xray-iam-permission branch March 26, 2021 14:25
ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
…ray-iam-permission

fix: added iam permission for x-ray
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants