feat: not output cloudformation outputs section #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horike37
requested changes
Apr 8, 2020
There was a problem hiding this comment.
@CM-Kajiwara
Thank you for sending this PR 👍 Cool 🕶
The specification and implementation is good from my perspective and two comments left about test and doc as my review. Please check it out.
| }; | ||
| serverlessStepFunctions.compileStateMachines(); | ||
| expect(Object.keys(serverlessStepFunctions.serverless.service.provider | ||
| .compiledCloudFormationTemplate.Outputs).length).to.equal(0); |
There was a problem hiding this comment.
Could you add a test case which noOutput: false is explicitly set as well?
README.md
Outdated
| @@ -351,6 +351,15 @@ stepFunctions: | |||
| validate: true | |||
| ``` | |||
|
|
|||
| ### Disable Output Cloudformation Outputs section | |||
|
|
|||
| Disables output in Outputs section. | |||
There was a problem hiding this comment.
It may lack the explanation in what kind of situation would it be possible to use this.
What about updating something like this?
Disables output in the CloudFormation Outputs section. if you define many state-machines in serverless.yml, there is a possibility of reaching out a CloudFormation limits in which the maximum number of outputs is 60. If you define `noOutput: true`, you can prevent automatically output by this plugin.
horike37
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
@CM-Kajiwara
Thank you for the updates 👍
LGTM! will release a new version with this soon 💯
|
🎉 This PR is included in version 2.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
…ut-option feat: not output cloudformation outputs section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option suppresses output to the Outputs section of Cloudformation.
https://dev.classmethod.jp/articles/serverless-framework-stepfunctions-many-statemachine-workaround/