fix: #287 don't include Tags property if no tags provided #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global tags become optional for inheriting
| @@ -99,7 +99,12 @@ module.exports = { | |||
| let RoleArn; | |||
| let DependsOn = []; | |||
| let LoggingConfiguration; | |||
| const Tags = toTags(this.serverless.service.provider.tags); | |||
| let Tags; | |||
| if (typeof stateMachineObj.inheritGlobalTags !== 'undefined' && stateMachineObj.inheritGlobalTags === false) { | |||
There was a problem hiding this comment.
would stateMachineObj.inheritGlobalTags === false have sufficed without the explicit undefined check?
There was a problem hiding this comment.
Possibly?
I'm not as familiar with nodejs, but was trying to avoid a Key error if inheritGlobalTags isn't included for the state machine.
There was a problem hiding this comment.
right, I see, in this case you'll be fine, stateMachineObj.inheritGlobalTags === false would not match if inheritGlobalTags is missing
There was a problem hiding this comment.
Thanks @theburningmonk. Just pushed the update
theburningmonk
approved these changes
Dec 24, 2019
|
🎉 This PR is included in version 2.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
fix: serverless-operations#287 don't include Tags property if no tags provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global tags become optional for inheriting
fixes #287