-
-
Notifications
You must be signed in to change notification settings - Fork 459
feat(lambda-at-edge): support image optimization #829
Conversation
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 80.69% 80.33% -0.36%
==========================================
Files 57 63 +6
Lines 1937 2217 +280
Branches 434 500 +66
==========================================
+ Hits 1563 1781 +218
- Misses 314 376 +62
Partials 60 60
Continue to review full report at Codecov.
|
@danielcondemarin this is done, could you please review when you have some time? Unfortunately I don't know how to exclude the Will try to add more test coverage afterwards for imageOptimizer and also exclude some scripts from code coverage. |
export type ImageConfig = { | ||
deviceSizes: number[]; | ||
imageSizes: number[]; | ||
loader: "default" | "imgix" | "cloudinary" | "akamai"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need imgix
, cloudinary
, akamai
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I didn't try these other loaders, will check on it but I think they go directly to those URLs
Awesome work! 🤞 for a release including this one soon |
Hey guys, I can test this on a LOT of images if you'd like - this is in the alpha release? |
Fixes: #725 by supporting the image optimizer introduced in Next.js 10 and hence the image component.