Encrypting sensitive data on demand #16
Conversation
mahdiridho
force-pushed
the
feature/encryption
branch
from
a500c74 to
7582833
Compare
|
|
||
| // Mask sensitive attributes, remove null | ||
| const maskSensitiveAttributes = (key: string, value: JSONObject): JSONObject | string | undefined => { | ||
| const maskSensitiveAttributes = (key: string, value: any): JSONObject | string | undefined => { |
There was a problem hiding this comment.
Don't define types as any. It has to be JSONObject
| */ | ||
| if (!!this.cipherKey) { | ||
| const cipher = createCipheriv( | ||
| 'aes-256-ecb', |
There was a problem hiding this comment.
Any reason to use aes-256-ecb ? We should have the algorithm as an optional setting, with aes-256-cbc as a default.
An IV would need to be created for each encryption.
The response should be an object:
{
iv: 'xxxxxx',
encrypted: 'abcdef'
}When value is an array or an object, the String(value) won't return anything usable. For theses cases, the value should be stringified.
There was a problem hiding this comment.
I'd like to understand the reason behind using encryption?
We also need to understand if this is PII compliant. Encrypted values are decryptable if you have the encryption key.
If what we want is to be able to filter logs based on a known value, maybe hashing the value (with a non-reversible algorithm) is good enough and improves compliance?
| { | ||
| "name": "@serverless-guru/logger", | ||
| "version": "1.0.7", | ||
| "version": "1.0.8", |
There was a problem hiding this comment.
Comment for another PR.
This should be automated.
| */ | ||
| if (!!this.cipherKey) { | ||
| const cipher = createCipheriv( | ||
| 'aes-256-ecb', |
There was a problem hiding this comment.
I'd like to understand the reason behind using encryption?
We also need to understand if this is PII compliant. Encrypted values are decryptable if you have the encryption key.
If what we want is to be able to filter logs based on a known value, maybe hashing the value (with a non-reversible algorithm) is good enough and improves compliance?
3 participants
We have security concern for sensitive data to be pull in log. The logger masking is not fully help for debugging as we don't know the payload identifier when they are masked. So instead of mask the sensitive attributes, we can keep securing them with encryption tool as well as let them to be searchable on debugging.