Skip to content

Update legacy-coverage for Meteor 3 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

StorytellerCZ
Copy link
Contributor

A quick attempt to upgrade legacy-coverage for Meteor 3. Haven't tested, but I think this is a good start.

A quick attempt to upgrade legacy-coverage for Meteor 3,
StorytellerCZ added a commit to StorytellerCZ/meteor-coverage that referenced this pull request Jul 16, 2024
Following serut#91, this is an attempt to quickly update the main package for Meteor 3.
@StorytellerCZ StorytellerCZ mentioned this pull request Jul 16, 2024
@serut
Copy link
Owner

serut commented Jul 16, 2024

Hello ! Thanks for your MR. Did you test it ? I'm not working on Meteor right now so I cannot test it...

@alisnic
Copy link
Contributor

alisnic commented Jul 24, 2024

this will not be enough unfortunately, as the code uses Assets.getText, which is now async. See https://github.com/meteor/meteor/pull/13155/files.

Will try to find a workaround

Update: this will need to make configuration initialization async

Update 2: everything runs, but coverage is Unknown 0/0%

@jankapunkt jankapunkt changed the base branch from master to migration/3.0 August 1, 2024 06:03
@jankapunkt jankapunkt merged commit 1011656 into serut:migration/3.0 Aug 1, 2024
1 check passed
@jankapunkt
Copy link
Collaborator

Note: I merged this into an own branch migration/3.0 to continue to work on this as it's easier to work on a branch of this PR than to fiddle between fork and upstream.

@StorytellerCZ StorytellerCZ deleted the patch-1 branch August 1, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants