Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Bump Stackage to LTS-22.32 #304

Merged
merged 10 commits into from
Oct 14, 2024
Merged

[Chore] Bump Stackage to LTS-22.32 #304

merged 10 commits into from
Oct 14, 2024

Conversation

int-index
Copy link
Member

@int-index int-index commented Sep 18, 2024

This PR updates the Stackage resolver to LTS-22.32 (GHC 9.6.6) and makes the necessary changes to avoid build issues.

Resolves #285

@serokell-bot
Copy link
Contributor

serokell-bot commented Sep 18, 2024

3 Warnings
⚠️ In commit 74ed941 message is too long (73 chars), please keep its length within 72 characters.
See also [Note].
⚠️ Inappropriate title for PR.
Should start from issue ID (e.g. [#123]), [Chore] or [Style] tag.
Note: please use [Chore] also for tickets tracked internally on YouTrack.
⚠️ Bad issue ID in branch name.
Valid format for issue IDs: #123 or chore.

[Note]: Skip this check by adding wip, tmp or [temporary] to the commit subject. Fixup commits (marked with fixup! or squash!) are also exempt from this check.

Generated by 🚫 Danger

int-index and others added 9 commits September 26, 2024 00:36
Problem: we take nyan-interpolation from GitHub, which is harder
to manage than if we take it from Hackage.
Fortunately, the latest version is now available and suits us.

Solution: specify Hackage version of nyan-interpoation[-core]
in extra-deps.
Problem: this is a new warning which wants us to provide an explicit
kind signature for each type we define. It sounds too verbose to do.

Solution: disable this warning.
Problem: retryAfterInfo doesn't compile because the type of
readMaybe got more polymorphic in Universum.

Solution: specify explicitly that the argument is Text.
N.B. In the previous version it was String (due to the old type of
readMaybe), but Text is generally preferable, so we're changing it.
Problem: some lens-related things that we use got deprecated in
Universum.
Solution: do not use them, import them from Control.Lens instead.
…etty

Problem: build failure with newer versions of optparse-applicative
  Module ‘Options.Applicative.Help.Pretty’ does not export ‘displayS’
  Module ‘Options.Applicative.Help.Pretty’ does not export ‘renderPretty’
  Module ‘Options.Applicative.Help.Pretty’ does not export ‘text’

Solution: stop using functions that have been removed.
Problem: Cross-compilation to windows is broken.

Solution: Build 'bitvec' without 'simd' flag
Problem: `firefly` depends on `regex-pcre`, which fails to build in
certain configurations:

  regex-pcre > regex-pcre-0.95.0.0: library-dirs: /usr/lib is a relative path which makes no
  regex-pcre > sense (as there is nothing for it to be relative to). You can make paths
  regex-pcre > relative to the package database itself by using ${pkgroot}. (use --force to
  regex-pcre > override)
  regex-pcre > regex-pcre-0.95.0.0: dynamic-library-dirs: /usr/lib is a relative path which
  regex-pcre > makes no sense (as there is nothing for it to be relative to). You can make
  regex-pcre > paths relative to the package database itself by using ${pkgroot}. (use
  regex-pcre > --force to override)

The problem only occurs with `stack` on Windows. Therefore, there are
two possible workarounds: (a) use `cabal`, (b) drop Windows support.
However, we would like to support both build tools on all platforms if
possible.

Solution: replace `firefly` with `scotty`, a different web server
library that does not depend on `regex-pcre`.
@int-index int-index changed the title WIP: Bump Stackage to LTS-22.32 [Chore] Bump Stackage to LTS-22.32 Oct 14, 2024
@gromakovsky
Copy link
Member

Seems to supersede #284 also.

Copy link
Member

@gromakovsky gromakovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@int-index int-index merged commit 6986eeb into master Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update stack setup for upgrading GHC
4 participants