-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Bump Stackage to LTS-22.32 #304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Note]: Skip this check by adding Generated by 🚫 Danger |
Problem: we take nyan-interpolation from GitHub, which is harder to manage than if we take it from Hackage. Fortunately, the latest version is now available and suits us. Solution: specify Hackage version of nyan-interpoation[-core] in extra-deps.
Problem: this is a new warning which wants us to provide an explicit kind signature for each type we define. It sounds too verbose to do. Solution: disable this warning.
Problem: retryAfterInfo doesn't compile because the type of readMaybe got more polymorphic in Universum. Solution: specify explicitly that the argument is Text. N.B. In the previous version it was String (due to the old type of readMaybe), but Text is generally preferable, so we're changing it.
Problem: some lens-related things that we use got deprecated in Universum. Solution: do not use them, import them from Control.Lens instead.
…etty Problem: build failure with newer versions of optparse-applicative Module ‘Options.Applicative.Help.Pretty’ does not export ‘displayS’ Module ‘Options.Applicative.Help.Pretty’ does not export ‘renderPretty’ Module ‘Options.Applicative.Help.Pretty’ does not export ‘text’ Solution: stop using functions that have been removed.
Problem: Cross-compilation to windows is broken. Solution: Build 'bitvec' without 'simd' flag
int-index
force-pushed
the
int-index/lts-22
branch
from
September 25, 2024 21:37
137d9e5
to
a59030a
Compare
Problem: `firefly` depends on `regex-pcre`, which fails to build in certain configurations: regex-pcre > regex-pcre-0.95.0.0: library-dirs: /usr/lib is a relative path which makes no regex-pcre > sense (as there is nothing for it to be relative to). You can make paths regex-pcre > relative to the package database itself by using ${pkgroot}. (use --force to regex-pcre > override) regex-pcre > regex-pcre-0.95.0.0: dynamic-library-dirs: /usr/lib is a relative path which regex-pcre > makes no sense (as there is nothing for it to be relative to). You can make regex-pcre > paths relative to the package database itself by using ${pkgroot}. (use regex-pcre > --force to override) The problem only occurs with `stack` on Windows. Therefore, there are two possible workarounds: (a) use `cabal`, (b) drop Windows support. However, we would like to support both build tools on all platforms if possible. Solution: replace `firefly` with `scotty`, a different web server library that does not depend on `regex-pcre`.
int-index
changed the title
WIP: Bump Stackage to LTS-22.32
[Chore] Bump Stackage to LTS-22.32
Oct 14, 2024
This was referenced Oct 14, 2024
Closed
Seems to supersede #284 also. |
gromakovsky
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Stackage resolver to LTS-22.32 (GHC 9.6.6) and makes the necessary changes to avoid build issues.
Resolves #285