应用部署在发行版tomcat的支持 #1532
应用部署在发行版tomcat的支持 #1532
Conversation
Signed-off-by: Yaxx19 <yaxx19@foxmail.com>
Signed-off-by: Yaxx19 <yaxx19@foxmail.com>
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| essentialPackage = ConfigManager.getConfig(InjectConfig.class).getEssentialPackage(); | ||
| } | ||
|
|
||
| protected boolean isSermantClass(String name) { |
There was a problem hiding this comment.
add Javadoc comment for isSermantClass and isSermantResource
| @@ -0,0 +1,44 @@ | |||
| package io.sermant.core.plugin.agent.enhance; | |||
There was a problem hiding this comment.
Add copy right and licence for all new class files. You can refer to https://github.com/sermant-io/Sermant/blob/6b2582d346fef1ad358c1b408697b1c8749d6ff7/sermant-backend/src/main/java/io/sermant/backend/handler/config/ServiceRegistryPluginHandler.java
| import java.util.logging.Logger; | ||
|
|
||
| /** | ||
| * 发行版Tomcat ClassLoader getResourceAsStream 增强 |
There was a problem hiding this comment.
i hope all comments could be in english, As well as PR description and commit message
|
Make sure you have squashed your change to one single commit. |
|
Have you ever test this in war and tomcat？ |
|
@Yaxx19 could you resolve conversations and confilcts above? |
What type of PR is this?
发行版tomcat的支持
What this PR does / why we need it?
对tomcat的org.apache.catalina.loader.WebappClassLoaderBase进行增强
织入点选择loadClass和getResourceAsStream
Which issue(s) this PR fixes？
Fixes #1519
Does this PR introduce a user-facing change?
No
Checklist