fix(e2e): more test fixes

e2e-tests/codecept.config.ts

@@ -1,11 +1,9 @@
-import config from './config'
+import { configInput } from './config'
+import { loginAsAdmin } from './tests/helpers/login-as-admin'
 
-const { isCI, browser, frontendUrl } = config
+const { isCI, browser, frontendUrl, adminUser, isChromium } = configInput
 
-const useLocalAPI = process.env.FRONTEND_API == 'local'
-export const adminUser = useLocalAPI ? 'admin' : 'Kulla'
-
-const isChromium = browser === 'chromium'
+export { adminUser }
 
 exports.config = {
   tests: 'tests/**.ts',
@@ -16,13 +14,12 @@ exports.config = {
       restart: 'keep',
       keepBrowserState: true,
       keepCookies: true,
-      show: isCI ? false : true,
+      show: !isCI,
       waitForTimeout: 30_000,
       ...(isCI && isChromium
         ? {
-            chromium: {
-              args: ['--no-sandbox'], // this is needed for github CI to work
-            },
+            // this is needed for github CI to work
+            chromium: { args: ['--no-sandbox'] },
           }
         : { browser }),
     },
@@ -41,18 +38,7 @@ exports.config = {
       inject: 'login',
       users: {
         admin: {
-          login: (I: CodeceptJS.I) => {
-            I.amOnPage('/')
-            I.see('Anmelden')
-            I.click('Anmelden')
-            I.waitForText('Benutzername oder E-Mailadresse', 10)
-            I.fillField('Benutzername oder E-Mailadresse', adminUser)
-            I.fillField('Passwort', '123456')
-            I.click('Anmelden', "button[value='password']")
-            I.waitForText(`Willkommen ${adminUser}!`, 30)
-            // Wait as a fix for: https://github.com/microsoft/playwright/issues/20749
-            I.wait(1)
-          },
+          login: loginAsAdmin,
           check: (I: CodeceptJS.I) => {
             I.amOnPage('/')
             I.waitForElement(`header nav img[alt='Avatar']`, 15)
@@ -64,14 +50,8 @@ exports.config = {
       },
     },
     ...(isCI ? {} : { pauseOnFail: {} }),
-    retryFailedStep: {
-      enabled: true,
-    },
-    tryTo: {
-      enabled: true,
-    },
-    screenshotOnFail: {
-      enabled: true,
-    },
+    retryFailedStep: { enabled: true },
+    tryTo: { enabled: true },
+    screenshotOnFail: { enabled: true },
   },
 }

e2e-tests/config.ts

@@ -1,20 +1,21 @@
 import dotenv from 'dotenv'
 
-function createConfig() {
+const localUrl = 'http://localhost:3000'
+const stagingUrl = 'https://de.serlo-staging.dev'
+
+export const configInput = (() => {
   dotenv.config()
 
-  const useLocalAPI = process.env.FRONTEND_API == 'local'
+  const isCI = Boolean(process.env.CI)
+  const browser = process.env.BROWSER ?? 'chromium'
+  const localApi = process.env.FRONTEND_API === 'local'
+
+  const defaultUrl = localApi ? localUrl : stagingUrl
+  const frontendUrl = process.env.FRONTEND_URL ?? defaultUrl
 
-  return {
-    isCI: Boolean(process.env.CI),
-    browser: process.env.BROWSER ?? 'chromium',
-    frontendUrl:
-      process.env.FRONTEND_URL ?? useLocalAPI
-        ? 'http://localhost:3000'
-        : 'https://de.serlo-staging.dev',
-  }
-}
+  const adminUser = localApi ? 'admin' : 'Kulla'
 
-const config = createConfig()
+  const isChromium = browser === 'chromium'
 
-export default config
+  return { isCI, browser, frontendUrl, adminUser, isChromium }
+})()

e2e-tests/tests/100-learners.ts

@@ -143,14 +143,15 @@ Scenario('Geogebra', ({ I }) => {
   I.waitForElement('canvas[data-test="euclidianView"]', 10)
 })
 
-Scenario('Video + Injection', ({ I }) => {
-  I.amOnPage('/277232')
-  I.scrollTo('#f7f13990')
-  I.see('dass externe Inhalte von')
-  I.click('Video abspielen von YouTube')
-  I.switchTo('iframe')
-  I.seeElement('video')
-})
+// deactivated for a while until youtube does not block us any more 😅
+// Scenario('Video + Injection', ({ I }) => {
+//   I.amOnPage('/277232')
+//   I.scrollTo('#f7f13990')
+//   I.see('dass externe Inhalte von')
+//   I.click('Video abspielen von YouTube')
+//   I.switchTo('iframe')
+//   I.seeElement('video')
+// })
 
 Scenario('Toggle Solution', ({ I }) => {
   I.amOnPage('/37779')
@@ -178,11 +179,10 @@ Scenario('Taxonomy', ({ I }) => {
   I.click('Klasse 7')
   I.see('Klasse 7')
   I.click('Grundwissenstest 7. Klasse')
-  I.see('Aufgaben')
+  I.waitForText('Aufgaben', 5)
   I.click('2021')
 
-  // Takes a long time to load
-  I.see('Berechne')
+  I.waitForText('Berechne', 5)
 
   I.amOnPage('/24370')
   I.see('Artikel')

e2e-tests/tests/421-text-plugin-formatting-options.ts

@@ -38,7 +38,7 @@ Scenario(
     I.type('https://de.serlo.org/mathe/1541/hypotenuse')
     I.click('$link-suggestion-0')
     I.click('Some text')
-    I.see('Hypotenuse')
+    I.waitForText('Hypotenuse', 10)
     I.seeElement({ css: '.serlo-editor-hacks a' })
 
     I.say('Toggle link off')
@@ -55,7 +55,7 @@ Scenario(
     // just to make sure we are in the right mode
     I.selectOption('$plugin-toolbar-math-type-switch', 'visuell')
     I.seeElement('span.mq-editable-field')
-    I.type('x / 2')
+    I.type('x/2')
     I.pressKey('ArrowRight')
     I.pressKey('ArrowRight')
     I.wait(1)
@@ -162,7 +162,7 @@ Scenario(
     I.say('Refocus link')
     I.click('Some text')
     I.click('Some text')
-    I.see('Hypotenuse')
+    I.waitForText('Hypotenuse', 10)
 
     I.say('Toggle link off via plugin bar')
     I.click('Some text')
@@ -233,7 +233,7 @@ Scenario(
     I.click('$plugin-toolbar-button-matheformel')
     I.selectOption('$plugin-toolbar-math-type-switch', 'visuell')
     I.seeElement('span.mq-editable-field')
-    I.type('x / 2')
+    I.type('x/2')
     I.pressKey('ArrowRight')
     I.pressKey('ArrowRight')
     I.wait(1)

e2e-tests/tests/helpers/login-as-admin.ts

@@ -0,0 +1,14 @@
+import { adminUser } from '../../codecept.config'
+
+export function loginAsAdmin(I: CodeceptJS.I) {
+  I.amOnPage('/')
+  I.see('Anmelden')
+  I.click('Anmelden')
+  I.waitForText('Benutzername oder E-Mailadresse', 10)
+  I.fillField('Benutzername oder E-Mailadresse', adminUser)
+  I.fillField('Passwort', '123456')
+  I.click('Anmelden', "button[value='password']")
+  I.waitForText(`Willkommen ${adminUser}!`, 30)
+  // Wait as a fix for: https://github.com/microsoft/playwright/issues/20749
+  I.wait(1)
+}