This repository was archived by the owner on Jul 17, 2024. It is now read-only.
Upgrade sqlx to 0.7.1 #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h to that now that there is no separate Actix-web feature any more
…rently that leads to >100 compilation errors that hopefully disappear when same change applied there as well
…qlx now uses a directory called .sqlx
AndreasHuber
force-pushed
the
upgrade-sqlx-to-0.7.0
branch
from
7736c4b to
cb21c7b
Compare
AndreasHuber
force-pushed
the
upgrade-sqlx-to-0.7.0
branch
from
cb21c7b to
6f87e54
Compare
…ng why test case fails
hugotiburtino
approved these changes
Jul 25, 2023
kulla
approved these changes
Jul 25, 2023
Comment on lines
-53
to
-58
| Ok(match connection { | ||
| Connection::Pool(pool) => fetch(path, instance, pool).await?, | ||
| Connection::Transaction(transaction) => { | ||
| fetch_via_transaction(path, instance, transaction).await? | ||
| } | ||
| }) |
There was a problem hiding this comment.
Nice to not have those lines any more :-)
| .await? | ||
| .map(|result| result.uuid_id as i32) | ||
| .ok_or(operation::Error::NotFoundError)? | ||
| } | ||
| }; | ||
|
|
||
| let uuid = Uuid::fetch_via_transaction(id, &mut transaction).await?; | ||
| let uuid = Uuid::fetch_via_transaction(id, &mut *transaction).await?; | ||
|
|
||
| transaction.commit().await?; |
There was a problem hiding this comment.
doesn't hurt either? Might be also faster since there is no rollback in the mysql...
| /// let events = sqlx::query!(r#"SELECT id FROM event_log"#).fetch_all(&mut transaction).await?; | ||
| /// let users = sqlx::query!(r#"SELECT id FROM user"#).fetch_all(&mut transaction).await?; | ||
| /// let events = sqlx::query!(r#"SELECT id FROM event_log"#).fetch_all(&mut *transaction).await?; | ||
| /// let users = sqlx::query!(r#"SELECT id FROM user"#).fetch_all(&mut *transaction).await?; |
There was a problem hiding this comment.
Yes because I have not entirely removed its usage yet, only where it was necessary to make database-layer compile again.
@AndreasHuber Can you do this in another PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Things to look out for when reviewing:
If you wonder how nested transactions work, check https://github.com/launchbadge/sqlx/blob/c70cfaf035b3ffcb1d6f244f6070e92646e83515/sqlx-core/src/transaction.rs#L242C1-L268C2.
Things that could make sense but are excluded here because the PR is already big:
Related info: