ci: extend commitlint in cli #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxuan
force-pushed
the
xuan.hu/commitlint-extends
branch
from
b3c4608 to
4c24048
Compare
msclock
reviewed
May 21, 2024
we are back here again😅 |
Yes, you are right. I usually prefer universal configuration if there are multiple tools needed. Since we do not need the configure for commitlint now, it is better to make it more explicitly. |
msclock
approved these changes
May 21, 2024
|
🎉 This PR is included in version 0.0.52 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By configuring the commitlint in cli directly, we do not need to configure it in
package.jsonand even do not need to checkout the repo.In the meanwhile, we can rename the
package.jsonto.releaserc.jsonas more explicitly configuration for semantic-release.BTW, since I have no experience about js code style or format, I would prefer to use
jsonconfiguration so as to leverage those json lint tools.