Skip to content

Clean-up project references #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Clean-up project references #172

wants to merge 5 commits into from

Conversation

rafaelsc
Copy link
Contributor

What issue does this PR address?
None. This is just a cleanup in the project references.

Does this PR introduce a breaking change?
Should not.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

@rafaelsc rafaelsc mentioned this pull request Jul 31, 2020
Closed
8 tasks
@nblumhardt
Copy link
Member

👍

Is it possible to replace the Serilog.Sinks.File.csproj netcoreapp3.1 target with netstandard2.1 with this also? Looking over the dependency graph, I think the app target here is superfluous.

@rafaelsc
Copy link
Contributor Author

rafaelsc commented Aug 3, 2020

I removed netcoreapp3.0 from the TargetFrameworks to netcoreapp3.0 use netstandard2.0 instead. I will update the #166 to have only netstandard2.1 removing the netcoreapp3.1

@Numpsy Numpsy mentioned this pull request Oct 6, 2020
Closed
@nblumhardt
Copy link
Member

I believe these changes came through now in #166.

@nblumhardt nblumhardt closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelsc @nblumhardt