Restore parallel tests execution #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! How on earth did you find that? 🎉 |
|
Well, I've become kind of an MSBuild expert in spite of myself over the years. The Also, I was pretty motivated because I already had spend way too much figuring out how to run test in parallel across target frameworks. 😄 |
|
Yes, .NET 8 enabled SourceLink by default. Happy the tool is helpful! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the tests execution time in half. On my machine: 76 seconds when run in parallel vs 144 seconds when run serially.
The fix introduced in 41bc33d (running
dotnet teston the csproj rather then on the built dlls) was problematic for two reasons.Serilog.Settings.Configuration.Tests.csprojin Debug instead of Release and it's unnecessary since it was previously built.The right fix was to disable deterministic source paths for the test project with
<DeterministicSourcePaths>false</DeterministicSourcePaths>. This way, the[CallerFilePath]attribute works as expected with absolute paths on the current machine instead of being substituted with/_/(which was causing the test failures). This looks like a breaking change that was introduced in the .NET 8 SDK.Also, I added back allowPrerelease = false and rollForward = latestFeature in the global.json file.