Upgrade from project.json to csproj #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Oct 5, 2019
| <AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile> | ||
| <SignAssembly>true</SignAssembly> | ||
| <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign> | ||
| <IsPackable>false</IsPackable> |
There was a problem hiding this comment.
This tag is not necessary.
There was a problem hiding this comment.
I think this could be beneficial later.
It lets just run dotnet pack on solution level.
sungam3r
reviewed
Oct 5, 2019
| <PackageTags>serilog;json</PackageTags> | ||
| <PackageIconUrl>http://serilog.net/images/serilog-extension-nuget.png</PackageIconUrl> | ||
| <PackageProjectUrl>https://github.com/serilog/serilog-formatting-compact</PackageProjectUrl> | ||
| <PackageLicenseUrl>http://www.apache.org/licenses/LICENSE-2.0</PackageLicenseUrl> |
There was a problem hiding this comment.
PackageLicenseUrl was marked as obsolete in favor of PackageLicenseExpression
sungam3r
reviewed
Oct 5, 2019
Comment on lines
19
to
21
| <GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute> | ||
| <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute> | ||
| <GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute> |
There was a problem hiding this comment.
This was automatically generated by dotnet migrate tool.
Changed.
|
👍 cheers! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this will be useful.