Skip to content

Extends ILoggerBuilder this resolves #84 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2017
Merged

Conversation

gertjvr
Copy link
Contributor

@gertjvr gertjvr commented Jul 17, 2017

Moved logging extensions to target ILoggingBuilder and updated the samples.

@gertjvr
Copy link
Contributor Author

gertjvr commented Jul 18, 2017

@nblumhardt It failed to download the dotnet sdk during the build, how do we rerun the build? or do I just commit something again.

Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Gert! Just one naming nitpick, otherwise looks good-to-go 👍

/// </summary>
public static class SerilogLoggerServicesExtensions
public static class SerilogLoggerLogBuilderExtensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this one should be SerilogLoggingBuilderExtensions

@nblumhardt nblumhardt merged commit 86aeba9 into serilog:dev Jul 18, 2017
@nblumhardt
Copy link
Member

👍

@nblumhardt nblumhardt mentioned this pull request Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants