Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #164 - suppress exceptions from FormattedLogValues #167

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Resolves #164 - suppress exceptions from FormattedLogValues #167

merged 1 commit into from
Mar 2, 2020

Conversation

nblumhardt
Copy link
Member

@gkinsman
Copy link

Looks good! I think it makes sense to fail silently into SelfLog and not attempt to write the log message with parameter holes. Would asserting on SelfLog having no output be a useful test for library authors to catch these bad events?

@nblumhardt
Copy link
Member Author

Thanks for taking a look. Asserting on the absence of SelfLog output, or on the presence of the expected events, would do the job; I'm not sure if Microsoft.Extensions.Logging provides it, but at least for Serilog, the SerilogAnalyzer VS plug-in catches these issues, too.

@nblumhardt nblumhardt merged commit c695457 into serilog:dev Mar 2, 2020
@nblumhardt
Copy link
Member Author

Thanks, George! Would be great to hear how the -dev package goes, should be on its way through CI -> NuGet now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkinsman gkinsman gkinsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nblumhardt @gkinsman