Make the level mapping routines public #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this, @serilog/reviewers-core ? |
|
LGTM ! 👍 I see it as extremely tempting to make them extension methods , but I suppose that YAGNI tells me that NO 🤷♂ (and if we were to do it, should the namespace be any different ? 🤔 ) |
|
I thought about this, but came out on the side of restraint since usage will be very, very infrequent (as far as I can tell). Extension methods do bring all kinds of namespace pollution concerns into the picture :-) .. Might just side-step that and |
|
Thanks for the review, BTW! :-) |
|
when will this feature be released? |
|
@xrkolovos thanks for the nudge; no plan yet, but #145 is the PR to watch. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's any library where this belongs, I guess it's here. Resolves #81.
No tests, as they'd be pretty much an exact copy of the already-declarative code.