Fix minimum level overrides in reloadable loggers #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to observe the value of SourceContext properties
|
Also sending this fix through the pipeline for the downstream Serilog.AspNetCore release. Test coverage in the newer code isn't great - looking forward to bulking it up a bit in the near future :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that wrapped loggers have a chance to observe the value of SourceContext properties. Previous behavior was to preemptively construct enrichers, which are opaque to the wrapped logger.
This PR skips the preemptive enricher construction for types that are "safe" to hang onto in closures, including the strings ultimately used for
SourceContext.Fixes #42 .