Fix crash on apps built with PublishTrimmed=True #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that
Serilog.Expressions
produces nasty startup crash when an app that uses this lib is built withPublishTrimmed=true
:Reproduction repo: https://github.com/malciin/serilog-expressions-trim-crash
I've investigated it and found that's because
_nameResolver
does not have any operator registered in it at all because those operators are trimmed away.serilog-expressions/src/Serilog.Expressions/Expressions/Compilation/Linq/LinqExpressionCompiler.cs
Line 102 in ccb6b01
Adding
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)]
toStaticMemberNameResolver
fixes it.Repo with fixed app: https://github.com/malciin/serilog-expressions/tree/dev-trimmed-test-app/src/SerilogTrimTestApp