Skip to content

Adding source context for the logging in RequestLoggingMiddleware. #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Adding source context for the logging in RequestLoggingMiddleware. #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Serilog.AspNetCore/AspNetCore/RequestLoggingMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,10 @@ public async Task Invoke(HttpContext httpContext)

bool LogCompletion(HttpContext httpContext, DiagnosticContextCollector collector, int statusCode, double elapsedMs, Exception ex)
{
var logger = Log.ForContext<RequestLoggingMiddleware>();
var level = statusCode > 499 ? LogEventLevel.Error : LogEventLevel.Information;

if (!Log.IsEnabled(level)) return false;
if (!logger.IsEnabled(level)) return false;

if (!collector.TryComplete(out var collectedProperties))
collectedProperties = NoProperties;
Expand All @@ -87,7 +88,7 @@ bool LogCompletion(HttpContext httpContext, DiagnosticContextCollector collector
});

var evt = new LogEvent(DateTimeOffset.Now, level, ex, _messageTemplate, properties);
Log.Write(evt);
logger.Write(evt);

return false;
}
Expand Down