Fix issue where string type would log to database with quotations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support logging properties into user defined columns
Fit the narrower layout of the project homepage. Includes XML configuration example.
…ssqlserver.git Conflicts: README.md
| new MessageTemplate("", new[] {new TextToken("Internal error while trying to write events to database")}), | ||
| Enumerable.Empty<LogEventProperty>()); | ||
|
|
||
| Emit(logEvent); |
There was a problem hiding this comment.
I do agree with some additional error handling and clearing the events table. But submitting another event can blow this thing up at some point.
|
Tested and merged. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.