Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added column mappings for sql bulk copy #10

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Added column mappings for sql bulk copy #10

merged 1 commit into from
Dec 23, 2015

Conversation

enginkirmaci
Copy link

  • added column mappings for sql bulk copy which maps also additional columuns.

@nblumhardt
Copy link
Contributor

Hi there- any notes to go with this change? Thanks!

@enginkirmaci
Copy link
Author

Hi @nblumhardt,
I made this change because of it gives me a string to Datetime parse error, while sql bulk copy. After a bit search, sql bulk copy didn't match columns automatically. if we don't provide mapping, it looks to same column order for table we created and db has. With this change we don't need the same order. So that, additional columns works.

@mivano mivano merged commit 94fb8e9 into serilog-mssql:master Dec 23, 2015
@mivano
Copy link
Contributor

mivano commented Dec 23, 2015

Merged, thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enginkirmaci @nblumhardt @mivano