Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does Serilog.Sinks.MsSqlServer support auditing? #110

Closed
j2jensen opened this issue Feb 8, 2018 · 3 comments
Closed

Does Serilog.Sinks.MsSqlServer support auditing? #110

j2jensen opened this issue Feb 8, 2018 · 3 comments

Comments

@j2jensen
Copy link

j2jensen commented Feb 8, 2018

I found this issue on the main serilog project asking about adding support for AuditTo.MsSqlServer, and the response was that auditing support is sink-specific and an issue or PR on this repo would be in order. However, I haven't seen any issues or pull requests on this repo related to Auditing support.

Has the auditing feature been added to this sink?
@tsimbalar
Copy link

tsimbalar commented Feb 8, 2018 •
edited
Loading

Hi James,

This has not been implemented yet, and no issue has been created. I guess this issue can be used to track it down, so that we at least have an issue open about it and collect comments and motivation :).

The resources are limited, and the MS Sql Server sink needs a bit of love, so if you are up to it, a Pull Request would be very welcome :)

In order to support Auditing, the sink would need to :

  • reference Serilog v2.5+ (I think AuditTo was added to the core Serilog library around that version)
  • add an extension method to LoggerAuditSinkConfiguration (in order to show up after AuditTo.

A quick search on github for the term LoggerAuditSinkConfiguration reveals that it is currently implemented in :

backlune pushed a commit to iCoreSolutions/serilog-sinks-mssqlserver that referenced this issue Apr 18, 2018
@alphaleonis @backlune
Feature/audit sink (#1)
9edb6e2 
* Updated reference to Serilog version 2.5.0 as suggested in serilog-mssql#110
* Added a new Sink `MSSqlServerAuditSink` that persists LogEvents to the database immediately and propagates any errors that occur.
* Moved, and refactored common functionality from `MSSqlServerSink` into `MSSqlServerSinkTraits` which is now used by both sinks.
@alphaleonis alphaleonis mentioned this issue Apr 18, 2018
Merged
@alphaleonis
Copy link
Contributor

Submitted a PR for this functionality, so hoping this will be integrated soon.

@mivano
Copy link
Contributor

mivano commented Apr 21, 2018

Merged, thanks.

@mivano mivano closed this as completed Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsimbalar @j2jensen @mivano @alphaleonis