Skip to content

Commit

Permalink
fix: update build tools and fix arm64 build for rpi (#111)
Browse files Browse the repository at this point in the history
Two problems to fix with this one
- our rpi arm64 isn't working possibly because our libc is too new, so we'll target the lts of arm64, worked for [level](Level/classic-level#71) thankful for [their investigation](Level/classic-level#69)
- our arm64 builds were just broken and wouldn't build so we're fixing that with a variable in our binding.gyp for `openssl_fips`

When this is released it will hopefully fix serialport/node-serialport#2438
  • Loading branch information
reconbot authored Apr 20, 2023
1 parent 21500b6 commit 7a8b86f
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 26 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: linux-arm
os: ubuntu-latest
command: prebuildify-cross
args: -i linux-arm64 -i linux-armv7 -i linux-armv6
args: -i linux-arm64-lts -i linux-armv7 -i linux-armv6
- name: android-arm
os: ubuntu-latest
command: prebuildify-cross
Expand Down
3 changes: 3 additions & 0 deletions binding.gyp
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
'variables': {
'openssl_fips': ''
},
'targets': [{
'target_name': 'bindings',
'sources': [
Expand Down
44 changes: 22 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"@serialport/bindings-interface": "1.2.2",
"@serialport/parser-readline": "^10.2.1",
"debug": "^4.3.2",
"node-addon-api": "^5.0.0",
"node-gyp-build": "^4.3.0"
"node-addon-api": "6.0.0",
"node-gyp-build": "4.6.0"
},
"devDependencies": {
"@semantic-release/exec": "6.0.3",
Expand All @@ -42,7 +42,7 @@
"eslint": "8.38.0",
"mocha": "10.2.0",
"node-abi": "3.40.0",
"node-gyp": "9.3.0",
"node-gyp": "9.3.1",
"nyc": "15.1.0",
"prebuildify": "5.0.1",
"prebuildify-cross": "5.0.0",
Expand Down

0 comments on commit 7a8b86f

Please sign in to comment.