Skip to content

Commit

Permalink
do not require xcolor with specific options
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiud committed Nov 3, 2024
1 parent 52f8248 commit bdcfc46
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 13 deletions.
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ To use the package, simply load `rebuttal` in the document preamble as follows:
\usepackage{rebuttal}
```

Also make sure the `xcolor` package has been loaded using the following options:

* `dvipsnames`
* `svgnames`
* `x11names`

Please refer to the
[letter](https://github.com/sergiud/rebuttal/blob/2e8839440c55e23de8dd05a7c0a0cef6f15ce23e/examples/letter.tex#L1)
example for necessary preamble setup.
Expand Down
24 changes: 17 additions & 7 deletions rebuttal.dtx
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
% \iffalse
%<package>\NeedsTeXFormat{LaTeX2e}
%<package>\ProvidesPackage{rebuttal}
%<package> [2024-11-03 v0.1.1 Markup for rebuttal letters]
%<package> [2024-11-03 v0.2.0 Markup for rebuttal letters]
%
%<*driver>
\ProvidesFile{rebuttal.dtx}

\documentclass[american,reportchangedates]{ltxdoc}
\documentclass[american,reportchangedates,svgnames]{ltxdoc}
\usepackage[abbreviations]{foreign}
\usepackage[utf8]{inputenc}
\usepackage[T1]{fontenc}
Expand Down Expand Up @@ -203,10 +203,6 @@
% \begin{macrocode}
%<*package>
% \end{macrocode}
% We need to load additional color sets.
% \begin{macrocode}
\PassOptionsToPackage{dvipsnames,svgnames,x11names}{xcolor}
% \end{macrocode}
% Package dependencies.
% \begin{macrocode}
\RequirePackage{calc}
Expand All @@ -220,6 +216,14 @@
\RequirePackage{ulem}
\RequirePackage{xcolor}
\RequirePackage{xstring}
% \end{macrocode}

% \changes{v0.2.0}{2024-11-XX}{Do not require loading \textsf{xcolor} with
% specific options}
% \begin{macrocode}
\providecolor{DodgerBlue3}{rgb}{.094,.455,.804}
\providecolor{Firebrick3}{rgb}{.804,.15,.15}
\providecolor{RedViolet}{RGB}{157,0,97}

\AtEndPreamble{
\RequirePackage{pdfcomment}
Expand Down Expand Up @@ -747,7 +751,13 @@
%
% \begin{macrocode}
%<*example1>
\documentclass[american,version=last,fromphone,fromemail,svgnames,dvipsnames,x11names]{scrlttr2}
\documentclass[american,version=last,fromphone,fromemail]{scrlttr2}
% \end{macrocode}
% Loading \textsf{xcolor} explicitly is not necessary. This line is solely used
% to ensure that the \textsf{rebuttal} package does not rely on specific
% \textsf{xcolor} options.
% \begin{macrocode}
\usepackage[]{xcolor}
\usepackage[T1]{fontenc}
\usepackage[utf8]{inputenc}
\usepackage[babel]{csquotes}
Expand Down

0 comments on commit bdcfc46

Please sign in to comment.