Add support for Remix v2 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 22, 2023
Closed
machour
reviewed
Jul 22, 2023
Co-authored-by: Mehdi Achour <machour@gmail.com>
Co-authored-by: Mehdi Achour <machour@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MichaelDeBoey
suggested changes
Aug 28, 2023
This follows what your original thinking was and it simplifies things because TypeScript is able to pick up the types for these files without any issues. I personally prefer this because it seems to do a better job of grouping similar utilities within a "subpackage" concept. But whatever you want to do I'm fine with.
This fixes this problem: Do this: 1. Open app in tab 1 2. Open app in tab 2 3. Submit form in tab 1 <-- CSRF error
|
@sergiodxa let me know if there is anything I can do to help here. I have a project I am testing out with the v2 pre and this is a blocker. |
|
@wking-io this is mostly done, in just waiting for v2 stable to be released |
|
@sergiodxa Since stable is released now, anything else why this is waiting? Anything I could help with? |
setvik
reviewed
Sep 28, 2023
This was referenced Oct 6, 2023
Closed
H1D
reviewed
May 4, 2024
There was a problem hiding this comment.
hmm.. why dynamic-links are gone? They seem to work perfectly with remix v2
There was a problem hiding this comment.
It's not needed anymore, MetaFunction can now return links tags based on data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Remix is preparing to release v2, this PR includes changes to internals and will mark a new major of Remix Utils that breaks compatibility with all Remix v1 versions.