Skip to content

Remove duplicate items from Guild.features' documentation #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

LikeLakers2
Copy link
Contributor

Hi! There really isn't much to this PR - it's just a documentation fix.

Specifically, in serenity::model::guild::Guild, the documentation for Guild.features featured a list of guild features - including three list items that were duplicates of previous items. This PR removes those three duplicates.

@github-actions github-actions bot added the model Related to the `model` module. label Aug 17, 2025
@jamesbt365
Copy link
Member

Can't speak for others but we should just remove the list of features, users can refer to the official discord docs or https://docs.discord.food (don't link this tho) for a list of features.

The official docs list is incomplete but contains enough for the common usecases, we shouldn't try and mirror the docs there to here.

@LikeLakers2
Copy link
Contributor Author

@jamesbt365 Do you want me to wait to see what others say on the matter, or do you want me to remove the rest of the items?

@GnomedDev
Copy link
Member

I agree with James, we should remove the raw list of features and just link to the discord documentation for that. I would also like to see a subtitle like "These are user-invisible options which are used for Discord rollouts and/or paid benefits" or something like that.

@LikeLakers2
Copy link
Contributor Author

So am I removing the rest of the items? Or is this planning for a future PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants