Fix public doctests that are marked ignore
#2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
arqunis
added
enhancement
arqunis
approved these changes
Sep 20, 2024
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the `CacheUpdate` trait as it was really out of date and not really possible to fix up.
GnomedDev
pushed a commit
that referenced
this pull request
Oct 7, 2024
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the `CacheUpdate` trait as it was really out of date and not really possible to fix up.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the `CacheUpdate` trait as it was really out of date and not really possible to fix up.
GnomedDev
pushed a commit
that referenced
this pull request
Oct 20, 2024
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the `CacheUpdate` trait as it was really out of date and not really possible to fix up.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the `CacheUpdate` trait as it was really out of date and not really possible to fix up.
GnomedDev
pushed a commit
that referenced
this pull request
Nov 13, 2024
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the `CacheUpdate` trait as it was really out of date and not really possible to fix up.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the `CacheUpdate` trait as it was really out of date and not really possible to fix up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctests on public items should be maintained accurate as the API changes, so having them be type-checked makes the most sense. I removed the doctest for the
CacheUpdatetrait as it was really out of date and not really possible to fix up.