Remove methods on ClientBulder that don't serve a purpose
#2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbt365
approved these changes
Aug 23, 2024
GnomedDev
approved these changes
Aug 23, 2024
arqunis
added
enhancement
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
…-rs#2953) The `ClientBuilder` struct is gated behind the `gateway` feature, which means that the client will receive the current application ID over the gateway when first authenticating. Therefore it doesn't make sense to set the application ID through the `ClientBuilder` as it will get overrided anyway. Also, the `get_token` method is pretty useless because the only source of the token would be whatever the user would have passed to `ClientBuilder::new`, meaning they would already have a way to read out its value.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
…-rs#2953) The `ClientBuilder` struct is gated behind the `gateway` feature, which means that the client will receive the current application ID over the gateway when first authenticating. Therefore it doesn't make sense to set the application ID through the `ClientBuilder` as it will get overrided anyway. Also, the `get_token` method is pretty useless because the only source of the token would be whatever the user would have passed to `ClientBuilder::new`, meaning they would already have a way to read out its value.
GnomedDev
pushed a commit
that referenced
this pull request
Oct 20, 2024
The `ClientBuilder` struct is gated behind the `gateway` feature, which means that the client will receive the current application ID over the gateway when first authenticating. Therefore it doesn't make sense to set the application ID through the `ClientBuilder` as it will get overrided anyway. Also, the `get_token` method is pretty useless because the only source of the token would be whatever the user would have passed to `ClientBuilder::new`, meaning they would already have a way to read out its value.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
…-rs#2953) The `ClientBuilder` struct is gated behind the `gateway` feature, which means that the client will receive the current application ID over the gateway when first authenticating. Therefore it doesn't make sense to set the application ID through the `ClientBuilder` as it will get overrided anyway. Also, the `get_token` method is pretty useless because the only source of the token would be whatever the user would have passed to `ClientBuilder::new`, meaning they would already have a way to read out its value.
GnomedDev
pushed a commit
that referenced
this pull request
Nov 13, 2024
The `ClientBuilder` struct is gated behind the `gateway` feature, which means that the client will receive the current application ID over the gateway when first authenticating. Therefore it doesn't make sense to set the application ID through the `ClientBuilder` as it will get overrided anyway. Also, the `get_token` method is pretty useless because the only source of the token would be whatever the user would have passed to `ClientBuilder::new`, meaning they would already have a way to read out its value.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
…-rs#2953) The `ClientBuilder` struct is gated behind the `gateway` feature, which means that the client will receive the current application ID over the gateway when first authenticating. Therefore it doesn't make sense to set the application ID through the `ClientBuilder` as it will get overrided anyway. Also, the `get_token` method is pretty useless because the only source of the token would be whatever the user would have passed to `ClientBuilder::new`, meaning they would already have a way to read out its value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClientBuilderstruct is gated behind thegatewayfeature, which means that the client will receive the current application ID over the gateway when first authenticating. Therefore it doesn't make sense to set the application ID through theClientBuilderas it will get overrided anyway.Also, the
get_tokenmethod is pretty useless because the only source of the token would be whatever the user would have passed toClientBuilder::new, meaning they would already have a way to read out its value.