Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip parsing attributes from rustfmt or clippy #2473

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

arqunis
Copy link
Member

@arqunis arqunis commented Jun 23, 2023

This alters attribute parse code in command_attr to not parse attributes like #[rustfmt::skip] as its own, and instead should emit them in the output of the macros.

@arqunis arqunis added fix A solution to an existing bug. command_attr Related to the `command_attr` crate. labels Jun 23, 2023
@arqunis arqunis mentioned this pull request Jun 23, 2023
@arqunis arqunis merged commit 16bfbe2 into serenity-rs:next Jun 23, 2023
@arqunis arqunis deleted the skip_tool_attributes branch June 23, 2023 22:50
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
This alters attribute parse code in `command_attr` to not parse attributes like `#[rustfmt::skip]` as its own, and instead should emit them in the output of the macros.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
This alters attribute parse code in `command_attr` to not parse attributes like `#[rustfmt::skip]` as its own, and instead should emit them in the output of the macros.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
This alters attribute parse code in `command_attr` to not parse attributes like `#[rustfmt::skip]` as its own, and instead should emit them in the output of the macros.
arqunis added a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
This alters attribute parse code in `command_attr` to not parse attributes like `#[rustfmt::skip]` as its own, and instead should emit them in the output of the macros.
arqunis added a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
This alters attribute parse code in `command_attr` to not parse attributes like `#[rustfmt::skip]` as its own, and instead should emit them in the output of the macros.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command_attr Related to the `command_attr` crate. fix A solution to an existing bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant