Fix "variable does not need to be mutable" warning #536
Conversation
|
|
||
| quote_block!(cx, { | ||
| let mut state = try!(_serializer.serialize_tuple_struct($type_name, $len)); | ||
| let $let_mut state = try!(_serializer.serialize_tuple_struct($type_name, $len)); | ||
| $serialize_stmts |
There was a problem hiding this comment.
@nox suggests rolling this into $serialize_stmts and generating:
let state = try!(...);
let mut state = state;where the initial call is never mut and $serialize_stmts includes "let mut state = state" if necessary.
There was a problem hiding this comment.
@nox I think I would rather move in the opposite direction, of making our generated code more straightforward where that can be accomplished easily. See as examples #479 and #538. There are a few reasons that is valuable:
- The most straightforward code will give us (and others) the best experience when the generated code needs to be debugged.
- The generated code is valuable as a template for implementing Serialize and Deserialize manually with minor modifications.
- Convoluted generated code gives people the impression that Serde is hard or Serde codegen is magic and impossible to understand, scaring people away from implementing Serialize and Deserialize manually where necessary.
I'm not saying we need to make the generated code beautiful at the expense of maintainability of serde_codegen, but there is a middle ground and I don't think rolling let mut state = state into $serialize_stmts is the right tradeoff in this case. Thanks for the idea though!
|
@homu r+ |
Fix "variable does not need to be mutable" warning Fixes #534. cc @elidupree
Fixes #534.
cc @elidupree