Add constructors for Bytes and ByteBuf #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `Bytes::new(&[u8])` and `ByteBuf::from<T: Into<Vec<u8>>>(T)`.
|
The constructor methods should probably be used wherever the objects are currently created manually. |
|
Done. I hope I got everything - I grepped for |
|
Done. I hope I got everything - I grepped for 'Bytes {' and 'ByteBuf {'. clippy should have a lint for that xD @homu r+ |
homu
added a commit
that referenced
this pull request
Sep 5, 2016
Add constructors for Bytes and ByteBuf This commit adds `Bytes::new(&[u8])` and `ByteBuf::from<T: Into<Vec<u8>>>(T)`. Fixes #519.
|
Merging because it passes on 1.8/1.9/beta/stable but I opened the PR before v0.8.5 so nightly won't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
Bytes::new(&[u8])andByteBuf::from<T: Into<Vec<u8>>>(T).Fixes #519.