Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

Fix pretty printing tuple struct element attributes #76

Closed
wants to merge 1 commit into from

Conversation

erickt
Copy link

@erickt erickt commented Jun 21, 2016

This backports rust-lang/rust#34310, which has not yet landed in a nightly yet, so we can't yet sync with the upstream libsyntax.

This backports rust-lang/rust#34310,
which has not yet landed in a nightly yet, so we can't yet
sync with the upstream libsyntax.
@dtolnay
Copy link
Contributor

dtolnay commented Jun 21, 2016

That PR merged 3 days ago. At what point does it land in nightly? I would have thought the next day.

@erickt
Copy link
Author

erickt commented Jun 21, 2016

@dtolnay: nightlies hasn't been built since the 15th :( I'll poke folks on #rust-internals.

@dtolnay
Copy link
Contributor

dtolnay commented Jun 21, 2016

Really? I did rustup update and got rustc 1.11.0-nightly (5522e678b 2016-06-20).

@dtolnay
Copy link
Contributor

dtolnay commented Jun 21, 2016

And it has the commit.

$ git branch --contains 9de2de1
* (HEAD detached at 5522e67)

@erickt
Copy link
Author

erickt commented Jun 21, 2016

Really? weird. This is what I'm getting:

➜  esprit git:(master) rustup update
info: syncing channel updates for 'stable-x86_64-apple-darwin'
info: syncing channel updates for 'beta-x86_64-apple-darwin'
info: syncing channel updates for 'nightly-x86_64-apple-darwin'
info: syncing channel updates for '1.8.0-x86_64-apple-darwin'
info: syncing channel updates for '1.9.0-x86_64-apple-darwin'
info: checking for self-updates
info: rustup is up to date

   stable-x86_64-apple-darwin unchanged - rustc 1.9.0 (e4e8b6668 2016-05-18)
     beta-x86_64-apple-darwin unchanged - rustc 1.10.0-beta.2 (39f3c16cc 2016-05-26)
  nightly-x86_64-apple-darwin unchanged - rustc 1.11.0-nightly (bb4a79b08 2016-06-15)
    1.8.0-x86_64-apple-darwin unchanged - rustc 1.8.0 (db2939409 2016-04-11)
    1.9.0-x86_64-apple-darwin unchanged - rustc 1.9.0 (e4e8b6668 2016-05-18)

➜  esprit git:(master) rustup run nightly rustc --version
rustc 1.11.0-nightly (bb4a79b08 2016-06-15)

@dtolnay
Copy link
Contributor

dtolnay commented Jun 21, 2016

I am on nightly-x86_64-unknown-linux-gnu so maybe only darwin is broken. I am curious what #rust-internals tells you.

In any case this is going to be included in #75 which I am working on.

@dtolnay dtolnay closed this Jun 21, 2016
@erickt
Copy link
Author

erickt commented Jun 21, 2016

@alexcrichton forced a channel invalidation, which seems to have gotten things to have cleared things up.

And woo on #75 :) No I haven't started working on that yet.

@dtolnay
Copy link
Contributor

dtolnay commented Jun 21, 2016

I confirmed that this is included in #77/syntex_syntax/src/print/pprust.rs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants