url: handle unicode hostname if empty

PR-URL: nodejs/node#49396 Fixes: nodejs/node#48759 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher · Apr 25, 2024 · ae94700 · ae94700
1 parent 2bfb541
commit ae94700
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/graal-nodejs/src/node_url.cc b/graal-nodejs/src/node_url.cc
@@ -168,7 +168,7 @@ void BindingData::Format(const FunctionCallbackInfo<Value>& args) {
     out->hash = std::nullopt;
   }
 
-  if (unicode) {
+  if (unicode && out->has_hostname()) {
     out->host = ada::idna::to_unicode(out->get_hostname());
   }
 

diff --git a/graal-nodejs/test/parallel/test-url-format-whatwg.js b/graal-nodejs/test/parallel/test-url-format-whatwg.js
@@ -140,3 +140,8 @@ assert.strictEqual(
   url.format(new URL('http://user:pass@xn--0zwm56d.com:8080/path'), { unicode: true }),
   'http://user:pass@测试.com:8080/path'
 );
+
+assert.strictEqual(
+  url.format(new URL('tel:123')),
+  url.format(new URL('tel:123'), { unicode: true })
+);