Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include add'l metadata in resolved addresses #12

Merged
merged 1 commit into from
May 2, 2020

Conversation

jhump
Copy link
Contributor

@jhump jhump commented May 1, 2020

This allows for implementing custom balancers that might be interested in additional information about the target endpoints.

This adds the endpoint reference (typically a pod reference) and its labels to the Attributes field of the resulting resolver.Address values.

@jhump
Copy link
Contributor Author

jhump commented May 1, 2020

@sercand, any chance you'd accept a small patch?

@sercand
Copy link
Owner

sercand commented May 2, 2020

@jhump Thanks for the PR

@sercand sercand merged commit b4d811d into sercand:master May 2, 2020
@jhump
Copy link
Contributor Author

jhump commented May 9, 2020

@sercand, looks like this can tickle issues in gRPC, where typical balancer implementations will churn connections (e.g. close all connections and re-establish all new ones). I've filed grpc/grpc-go#3611.

Not sure if you want to revert this PR until that is remedied or just hold off on a release. But I figured I should let you know. (This change worked great in test environments; but it just hit our production environment yesterday, where the scale of connection churn started causing some issues 😦).

@lvyijin
Copy link

lvyijin commented May 28, 2020

Hi,@sercand, we encountered the same problem as Jhump. And I would like to konw why changed Metadata interface{} in v1.19.1 to Attributes *attributes.Attributes in v1.26.0.

@sercand
Copy link
Owner

sercand commented May 28, 2020

I just reverted the changes. I haven't upgraded our gRPC version to the latest that's why I missed the problem. I will look for this as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants