Default service account support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't have to push long lived key files around
I'm adding the ability to use a system level service account so we do…
…the VM works, then you can use this and avoid shipping any long lived service account keys around.
Adding system level credentials. If your default service account for …
|
@glassrye thanks for your input, this is a great feature. Will you be so kind to expand the |
|
Ah! Of course, of course. I can't believe I forgot that part. Anyway, that has been added. Thanks so much for this great plugin! |
|
Anything that needs doing to get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had need to use a default service account that had read only permissions to GSM. I also had a requirement not to generate service account keys and ship credentials anywhere.
I updated the code to allow for a "system" level account that requires a project id be set as well.
This worked for my needs so I thought I would share. Appreciate any and all feedback!