Skip to content

🗑️ Drop column consumers.max_storage_mb #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acco
Copy link
Contributor

@acco acco commented May 30, 2025

No description provided.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 30, 2025
Copy link
Contributor Author

acco commented May 30, 2025

@dosubot dosubot bot added the refactor label May 30, 2025
@@ -65,6 +65,7 @@ defmodule Sequin.Runtime.ConsumerLifecycleEventWorker do
CheckSinkConfigurationWorker.enqueue(consumer.id)
RuntimeSupervisor.start_for_sink_consumer(consumer)
:ok = RuntimeSupervisor.refresh_message_handler_ctx(consumer.replication_slot_id)
:ok = SlotProcessorServer.monitor_message_store(consumer.replication_slot_id, consumer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 30, 2025
@acco acco force-pushed the acco/05-30-_remove_storage_param_from_slotmessagestore branch from f954c93 to a8f6ae6 Compare May 30, 2025 23:48
@acco acco force-pushed the acco/05-30-_wastebasket_drop_column_consumers.max_storage_mb branch from 2e6137b to 50fdbb0 Compare May 30, 2025 23:48
@acco acco force-pushed the acco/05-30-_remove_storage_param_from_slotmessagestore branch from a8f6ae6 to e867ff8 Compare May 30, 2025 23:49
@acco acco force-pushed the acco/05-30-_wastebasket_drop_column_consumers.max_storage_mb branch from 50fdbb0 to 1e31add Compare May 30, 2025 23:49
Base automatically changed from acco/05-30-_remove_storage_param_from_slotmessagestore to main May 30, 2025 23:49
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants