Fixed generated SQL when using find with through.where and required true - #4667
Merged
Conversation
Contributor
Author
|
Seems like my changes don't fix the problem on mssql databases.. I can probably get my hands on one to see what the problem is |
Contributor
Otherwise great work, if you feel like taming mssql we'd be happy, but otherwise i'm okay with just skipping this test for mssql untill we can get an expert on it. |
…rue and the primary key attribute is different from the primary key field
Contributor
Author
|
Found the problem, another primaryKeyAttribute on mssql's query-generator function 'addLimitAndOffset' The failing check now doesn't have anything to do with the change. |
mickhansen
added a commit
that referenced
this pull request
Oct 19, 2015
Fixed generated SQL when using find with through.where and required true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the primary key attribute is different from the primary key field
Kind of relates to ##3940. Using the primaryKeyAttribute generates wrong SQL if the database field and the model attributes are named differently.