Skip to content

Directly read blob contents without copying to memory#306

Merged
at-wat merged 1 commit intomasterfrom
directly-read-blob-without-copy-to-mem
Jul 16, 2025
Merged

Directly read blob contents without copying to memory#306
at-wat merged 1 commit intomasterfrom
directly-read-blob-without-copy-to-mem

Conversation

@at-wat
Copy link
Member

@at-wat at-wat commented Jul 16, 2025

Reduce peak memory usage during map load.

Previous implementation copied whole JS blob contents to memory and read via bytes.Reader.
New implementation adds a wrapper to directly read JS blob contents as io.Reader.

So, the peak memory usage during map load should be halved.

@at-wat at-wat self-assigned this Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (fb95330) to head (c59d5e2).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   38.16%   38.16%           
=======================================
  Files           8        8           
  Lines        1643     1643           
=======================================
  Hits          627      627           
  Misses        980      980           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@at-wat at-wat requested a review from f-fl0 July 16, 2025 06:59
Copy link
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit b89f64f into master Jul 16, 2025
5 checks passed
@at-wat at-wat deleted the directly-read-blob-without-copy-to-mem branch July 16, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants