Skip to content

Fix sampling ratio to make the 'stride' value valid in gl.VertexAttribIPointer calls#261

Merged
f-fl0 merged 1 commit intomasterfrom
fast-render/fix-sampling-ratio
Nov 21, 2024
Merged

Fix sampling ratio to make the 'stride' value valid in gl.VertexAttribIPointer calls#261
f-fl0 merged 1 commit intomasterfrom
fast-render/fix-sampling-ratio

Conversation

@f-fl0
Copy link
Contributor

@f-fl0 f-fl0 commented Nov 20, 2024

I ran into the following warning when setting num_fast_render_points to 1000000 with a point cloud containing about 24 millions points:
image
In this case, the point cloud completely disappears when moving the viewpoint. This PR makes sure samplingRatio is adjusted to prevent the stride value to be over 255 in gl.VertexAttribIPointer calls.

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (97c5aa6) to head (df33469).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   38.16%   38.16%           
=======================================
  Files           8        8           
  Lines        1643     1643           
=======================================
  Hits          627      627           
  Misses        980      980           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@f-fl0 f-fl0 requested a review from at-wat November 21, 2024 00:11
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-fl0 f-fl0 merged commit 25a1a1b into master Nov 21, 2024
@f-fl0 f-fl0 deleted the fast-render/fix-sampling-ratio branch November 21, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants