Skip to content

Support large pcd#259

Merged
at-wat merged 14 commits intomasterfrom
support-large-pcd
Nov 20, 2024
Merged

Support large pcd#259
at-wat merged 14 commits intomasterfrom
support-large-pcd

Conversation

@at-wat
Copy link
Member

@at-wat at-wat commented Nov 20, 2024

  • Fix large map (>30M points) rendering on Firefox
  • Reduce number of points to render while moving the viewpoint

@at-wat at-wat self-assigned this Nov 20, 2024
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 38.16%. Comparing base (10d9969) to head (295c32a).

Files with missing lines Patch % Lines
command.go 11.11% 8 Missing ⚠️
console.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   39.39%   38.16%   -1.24%     
==========================================
  Files           8        8              
  Lines        1396     1643     +247     
==========================================
+ Hits          550      627      +77     
- Misses        810      980     +170     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@at-wat at-wat requested a review from f-fl0 November 20, 2024 08:42
@at-wat at-wat requested a review from f-fl0 November 20, 2024 09:49
Copy link
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit e516274 into master Nov 20, 2024
@at-wat at-wat deleted the support-large-pcd branch November 20, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants