Conversation
Codecov ReportBase: 38.49% // Head: 38.49% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 38.49% 38.49%
=======================================
Files 8 8
Lines 1626 1626
=======================================
Hits 626 626
Misses 964 964
Partials 36 36 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
at-wat
left a comment
at-wat
left a comment
There was a problem hiding this comment.
It seems depending on Go version.
I think we need to fallback to global.* if globalThis.* is not available.
Fix if/else formatting Co-authored-by: Atsushi Watanabe <atsushi.w@ieee.org>
pcdeditor.js
Outdated
| go.run(instance) | ||
| } | ||
| if (typeof global === 'undefined' || typeof global.Go === 'undefined') { | ||
| if (typeof globalThis === 'undefined' || typeof globalThis.Go === 'undefined') { |
There was a problem hiding this comment.
I think this condition should also handle global.Go.
Co-authored-by: Atsushi Watanabe <atsushi.w@ieee.org>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pcdeditor.js
Outdated
| } | ||
| if (typeof global === 'undefined' || typeof global.Go === 'undefined') { | ||
| if ((typeof globalThis === 'undefined' || typeof globalThis.Go === 'undefined') && | ||
| (typeof global === 'undefined' || typeof global.Go === 'undefined') { |
There was a problem hiding this comment.
🚫 [eslint] reported by reviewdog 🐶
Parsing error: ')' expected.
pcdeditor.js
Outdated
| }) | ||
| .then((yamlBlob) => { | ||
| const img = new global.Image() | ||
| const img = new globalThis.Image() |
There was a problem hiding this comment.
| const img = new globalThis.Image() | |
| const img = new Image() |
2 participants
I ran into the following error when trying to accessing
pcdeditorathttp://localhost:8080/after runningmake. RenamingglobaltoglobalThisseems to solve the issue.