Skip to content

Functions to modify points labels#154

Merged
f-fl0 merged 12 commits intomasterfrom
relabel-points-in-specified-label-range
Jun 29, 2022
Merged

Functions to modify points labels#154
f-fl0 merged 12 commits intomasterfrom
relabel-points-in-specified-label-range

Conversation

@f-fl0
Copy link
Contributor

@f-fl0 f-fl0 commented Jun 29, 2022

This PR adds a couple of function to modify the points labels based on a specified label range or a list of labels to keep unchanged. Here is a video of these features in action:

modify_points_labels.mp4

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #154 (0592eba) into master (adfb1fe) will increase coverage by 1.51%.
The diff coverage is 65.88%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   36.98%   38.49%   +1.51%     
==========================================
  Files           8        8              
  Lines        1541     1626      +85     
==========================================
+ Hits          570      626      +56     
- Misses        941      964      +23     
- Partials       30       36       +6     
Impacted Files Coverage Δ
console.go 8.79% <0.00%> (-0.33%) ⬇️
command.go 27.65% <64.70%> (+0.86%) ⬆️
editor.go 69.40% <78.94%> (+2.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfb1fe...0592eba. Read the comment docs.

@f-fl0 f-fl0 requested a review from at-wat June 29, 2022 03:04
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to avoid expanding default menu items too much.
What do you think?

@f-fl0
Copy link
Contributor Author

f-fl0 commented Jun 29, 2022

I think it's better to avoid expanding default menu items too much.

You are probably right. I can try to put those new options to another menu (e.g. advanced or something) or take them out completely. The added functions can be triggered via the command panel anyway.

@f-fl0 f-fl0 requested a review from at-wat June 29, 2022 04:57
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add commands to README.md?

@f-fl0 f-fl0 requested a review from at-wat June 29, 2022 07:19
Improve help message

Co-authored-by: Atsushi Watanabe <atsushi.w@ieee.org>
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-fl0 f-fl0 merged commit 9fe0902 into master Jun 29, 2022
@f-fl0 f-fl0 deleted the relabel-points-in-specified-label-range branch June 29, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants