Skip to content

sctp: fix outgoing SACK corruption on DATA chunk reception #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-c-n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sctp: fix outgoing SACK corruption on DATA chunk reception #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/sctp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,24 @@ void sctp_incoming_data(Sctp* sctp, char* buf, size_t len) {
length += ntohs(data_chunk->length);
} else if (ntohl(data_chunk->ppid) == DATA_CHANNEL_PPID_DOMSTRING || ntohl(data_chunk->ppid) == DATA_CHANNEL_PPID_BINARY) {
if (sctp->onmessage) {
/*
* In case the "onmessage" callback sends a DATA chunk, we
* send the SACK first, and stop the processing after the
* callback.
*/
out_packet->header.source_port = htons(sctp->local_port);
out_packet->header.destination_port = htons(sctp->remote_port);
out_packet->header.verification_tag = sctp->verification_tag;
out_packet->header.checksum = 0x00;
if (length > 0) {
// padding 4
length = (4 * ((length + 3) / 4));
out_packet->header.checksum = sctp_get_checksum(sctp, sctp->buf, length);
dtls_srtp_write(sctp->dtls_srtp, sctp->buf, length);
}
sctp->onmessage((char*)data_chunk->data, ntohs(data_chunk->length) - sizeof(SctpDataChunk),
sctp->userdata, ntohs(data_chunk->sid));
return;
}
}
pos = len; // Do not handle other msg
Expand Down