Rename "failures" to "failed" in qless-stats #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlecocq
force-pushed
the
qless-stats-graphite
branch
from
7fb8e3f
to
f3ced33
Compare
b4hand
approved these changes
Jan 16, 2018
|
I think it'd be a good idea to do at least one of those. On the version, I have two minds about it -- it doesn't really change the core functionality, but I'd hate for peoples' alerts to break all of a sudden. I guess now that I say it aloud, probably deserves a 0.12.0 bump. I'll add a section on release notes. |
dlecocq
force-pushed
the
qless-stats-graphite
branch
from
f3ced33
to
61b57fb
Compare
|
@b4hand -- updated |
b4hand
approved these changes
Jan 16, 2018
Graphite/whisper cannot have a name that serves both as a metric name and as a dot-delimited prefix to another metric. Because individual failure types are reported as "failures.<type>", the "failures" metric fails to be reported if ever there has been a report of "failures.<type>". While this tool is not specific to graphite, it is a common tool in the monitoring ecosystem and it takes little effort to make this tool compatible.
dlecocq
force-pushed
the
qless-stats-graphite
branch
from
61b57fb
to
385da9d
Compare
|
Build finally passed (there was one flaky build, and then Travis was being slow). Should be good to go to hit the merge button, @b4hand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphite/whisper cannot have a name that serves both as a metric name and as a dot-delimited prefix to another metric. Because individual failure types are reported as "failures.", the "failures" metric fails to be reported if ever there has been a report of "failures.". While this tool is not specific to graphite, it is a common tool in the monitoring ecosystem and it takes little effort to make this tool compatible.
@b4hand @evanbattaglia @kq2