Skip to content

Conversation

mzglinski
Copy link
Contributor

I just wanted to enable geoip on my instance and ended up doing this. 😄

Summary:

  • Added a lookup function to all Persistent Volume Claims (PVCs). This facilitates immutable fields during Helm upgrades and improves compatibility with plugins such as helm-diff, which is used by helmfile. Without the lookup, helmfile consistently detects changes and initiates upgrades. (Note: To fully utilize this, include --dry-run=server in your helmfile diff arguments.)
  • Implemented persistence support for symbolicator in deployment mode.
  • Enhanced geoip configuration options. The geoip volume necessitates ReadWriteMany access, which is often unavailable by default on managed Kubernetes services. For instance, in GKE, you can now deploy a fuse storage driver (object storage driver) and configure a volume for geoip using annotations and the extraManifests options.

@mzglinski
Copy link
Contributor Author

Hi @Mokto, as per #1851 (comment) do you want any changes here?

@mzglinski mzglinski force-pushed the feat/persistence-improvements branch from eb07d2f to a70e01e Compare September 3, 2025 14:45
@mzglinski mzglinski marked this pull request as draft September 3, 2025 15:32
@mzglinski
Copy link
Contributor Author

I found another bug: the PVC used to have hooks, which caused it to be removed before every upgrade. This must have never worked, as you cannot delete a PVC while its consumers are running. Therefore, I don't believe we need to classify this as a breaking change.

@mzglinski mzglinski marked this pull request as ready for review September 3, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant