Conversation
Restructure the core pattern matching components from DSL-based layout to a more organized engine architecture. Changes include: - Replace match_builder with engine/builder and engine/match modules - Add forward declarations header (fwd.h) - Move implementation details to engine/detail subdirectory - Remove legacy dsl/case_expr and dsl/operators headers This improves code organization by separating builder and match functionality while maintaining a clearer separation between interface and implementation details.
Reorganized the core module's namespace structure from ptn::dsl to ptn::core::dsl for better logical grouping. Added new common headers (diagnostics, eval, optimize, common_traits) to the CMakeLists installation. Updated namespaces in case_expr.hpp and operators.hpp files. Removed NAMESPACE export from CMake configuration. This refactoring improves code organization and clarifies the module hierarchy.
Move pattern-related traits (pattern_like concept, is_pattern, binding_args) from common_traits.hpp to the pattern/base/fwd.h module. This reorganization improves code modularity by placing pattern-specific abstractions in their dedicated module, reducing coupling between common utilities and pattern implementations. Updated references in diagnostics.hpp and common_traits.hpp to use the new location.
Update pattern matching to pass the subject as the first argument to handlers by concatenating it with bound arguments using tuple_cat. This change requires modifications to type traits to reflect the new invocation signature and enhances the pattern matching consistency across different handler types.
- Reorganize headers into logical modules: base/, meta/, pattern/, core/ - Update project version from 0.4.1 to 0.5.0 - Refactor namespace structure from ptn::pattern to ptn::pat - Move pattern base classes to dedicated pattern/base/ directory - Consolidate meta utilities into base/, dsa/, and query/ subdirectories - Remove benchmark_complex.cpp and update benchmark includes - Fix CMake configuration for proper install paths
Replace block Doxygen-style documentation comments with line comments throughout the codebase. This change standardizes comment formatting and improves code readability while maintaining all existing documentation content. The changes affect files in core, engine, pattern, and utility modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace Doxygen comments with Google C++ style comments