Update logging for unrunable pipelines #4843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sensu/sensu-enterprise-go/issues/2323
What is this change?
Makes logging adjustments for situations where an event processing pipeline can't be ran due to its configuration.
Fixes misleading log messages
Before either of these two situations resulted in a log line like this
pipeline has no workflows, skipping execution of pipeline
:Now the log message is specific to the later situation:
legacy pipeline found no existing handlers: none of [handlerDNE] exist, skipping execution of pipeline
.Adjusts log levels
Previously this log was emitted at a Warning level. I felt it was better at Info as there isn't necessarily anything wrong. Definitely debatable, though, as issues like these are difficult for users to debug.
Previously this log was omitted when the check name is "keepalive", as many clusters are likely to generate a lot of these due to the default keepalive handler we add on keepalive events. I thought including these at Info might be problematic, but especially with the addition of keepalive pipelines this can be tricky to troubleshoot, so I've included them at the Debug level.
Does your change need a Changelog entry?
I don't really think so.
Do you need clarification on anything?
N
Were there any complications while making this change?
N
Have you reviewed and updated the documentation for this change? Is new documentation required?
N/A
How did you verify this change?
Manual
Is this change a patch?
N