Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging for unrunable pipelines #4843

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

c-kruse
Copy link
Contributor

@c-kruse c-kruse commented Aug 12, 2022

Closes https://github.com/sensu/sensu-enterprise-go/issues/2323

What is this change?

Makes logging adjustments for situations where an event processing pipeline can't be ran due to its configuration.

Fixes misleading log messages
Before either of these two situations resulted in a log line like this pipeline has no workflows, skipping execution of pipeline:

  • (The obvious) An event references a pipeline for which no workflows are configured
  • (The misleading) An event has handlers specified, but none of the handlers exist.

Now the log message is specific to the later situation: legacy pipeline found no existing handlers: none of [handlerDNE] exist, skipping execution of pipeline.

Adjusts log levels

Previously this log was emitted at a Warning level. I felt it was better at Info as there isn't necessarily anything wrong. Definitely debatable, though, as issues like these are difficult for users to debug.

Previously this log was omitted when the check name is "keepalive", as many clusters are likely to generate a lot of these due to the default keepalive handler we add on keepalive events. I thought including these at Info might be problematic, but especially with the addition of keepalive pipelines this can be tricky to troubleshoot, so I've included them at the Debug level.

Does your change need a Changelog entry?

I don't really think so.

Do you need clarification on anything?

N

Were there any complications while making this change?

N

Have you reviewed and updated the documentation for this change? Is new documentation required?

N/A

How did you verify this change?

Manual

Is this change a patch?

N

Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
@c-kruse c-kruse requested a review from amdprophet August 12, 2022 17:04
@c-kruse c-kruse merged commit e2d8098 into develop/6 Aug 19, 2022
@c-kruse c-kruse deleted the Adjust-Legacy-Pipeline-Logging branch August 19, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants