Remove go mod replace usage #4732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
amdprophet
approved these changes
May 7, 2022
c-kruse
added a commit
that referenced
this pull request
May 12, 2022
* Remove go.mod replace directives from sensu modules Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * ignore go's multi-module workspace files Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * bump minimum go version to 1.16 Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * Update CONTRIBUTING.md with multi module dev workflow Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * Add CircleCI test to check for replace directives Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
c-kruse
added a commit
that referenced
this pull request
May 19, 2022
* Remove go.mod replace directives from sensu modules Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * ignore go's multi-module workspace files Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * bump minimum go version to 1.16 Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * Update CONTRIBUTING.md with multi module dev workflow Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * Add CircleCI test to check for replace directives Signed-off-by: Christian Kruse <ctkruse99@gmail.com> (cherry picked from commit 8395674)
c-kruse
added a commit
that referenced
this pull request
May 19, 2022
* Remove go.mod replace directives from sensu modules Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * ignore go's multi-module workspace files Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * bump minimum go version to 1.16 Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * Update CONTRIBUTING.md with multi module dev workflow Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * Add CircleCI test to check for replace directives Signed-off-by: Christian Kruse <ctkruse99@gmail.com> (cherry picked from commit 8395674) Update circleci config with new executors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
replacedirectives in our modules.Why is this change necessary?
To force us to keep sensu-go's internal dependencies updated.
Does your change need a Changelog entry?
Probably not. Does not affect the product.
Do you need clarification on anything?
N
Were there any complications while making this change?
I was hopeful to fit the CI check for replace directives in semgrep but didn't see any obvious ways to do so.
Have you reviewed and updated the documentation for this change? Is new documentation required?
N/A
How did you verify this change?
N/A
Is this change a patch?
N